♻️ redirect list_dynamic_services via dynamic-scheduler
#6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6893 +/- ##
==========================================
- Coverage 88.35% 88.16% -0.19%
==========================================
Files 1571 1411 -160
Lines 61614 58088 -3526
Branches 1999 1643 -356
==========================================
- Hits 54437 51212 -3225
+ Misses 6841 6593 -248
+ Partials 336 283 -53
Continue to review full report in Codecov by Sentry.
|
GitHK
changed the title
list_dynamic_services via dynamic-scheduler
GitHK
added
the
a:webserver
added 12 commits
December 3, 2024 14:53
…t-remain-dv2-calls-via-dynamic-scheduler
…t-remain-dv2-calls-via-dynamic-scheduler
…t-remain-dv2-calls-via-dynamic-scheduler
…t-remain-dv2-calls-via-dynamic-scheduler
GitHK
requested review from
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
sanderegg
approved these changes
Dec 4, 2024
packages/models-library/src/models_library/api_schemas_directorv2/dynamic_services_service.py
Show resolved
Hide resolved
pcrespov
reviewed
Dec 4, 2024
...dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/director_v2/_thin_client.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_trash_api.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/dynamic_scheduler/api.py
Show resolved
Hide resolved
added 3 commits
December 5, 2024 08:35
…t-remain-dv2-calls-via-dynamic-scheduler
added 2 commits
December 5, 2024 09:53
…t-remain-dv2-calls-via-dynamic-scheduler
pcrespov
approved these changes
Dec 5, 2024
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
OK. Please check the questions i left. thx
services/web/server/src/simcore_service_webserver/folders/_folders_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/dynamic_scheduler/api.py
Show resolved
Hide resolved
added 3 commits
December 5, 2024 11:07
…-remain-dv2-calls-via-dynamic-scheduler
|
GitHK
deleted the
pr-osparc-redirect-remain-dv2-calls-via-dynamic-scheduler
branch
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Redirecting
list_dynamic_servicesvia dynamic-scheduler. Webserver calls the endpoint via RPC like it does for: starting, stopping and getting the status of a service.NOTE: this is very noisy due to the mocks rename to better reflect the new circumstances.
Related issue/s
How to test
Dev-ops checklist